Repository navigation
Keep the Codex processor fixture as the first JSON example - #4
Closed
geldmacher wants to merge 1 commit into
Closed
geldmacher wants to merge 1 commit into
geldmacher wants to merge 1 commit into
Conversation
The release check reads the first JSON fence in the Codex RTK reference as the processor fixture. The hook metadata example was added above it, so hook_event_name was missing. Move Processor and live execution ahead of Hook metadata and trust. Co-authored-by: Dennis Geldmacher <geldmacher.dennis@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Validate job reads the first
jsonfence inskills/rtk-setup/references/codex.mdas the RTK processor fixture. The hook metadata example added inffdb77cbecame that first fence, sohook_event_namewasundefinedanddocumented RTK processor fixtures include each host's required input fieldsfailed.Move Processor and live execution ahead of Hook metadata and trust. The processor payload (
hook_event_name,tool_name,permission_mode) is the firstjsonfence again. The metadata handler example and the#hook-metadata-and-trustlink stay intact. Assertions are unchanged.Test plan
npm run release-checklocally (114/114, same gate as Validate)