feat: support explicit numeric cast expressions#28
Merged
Conversation
Define i64(expr) and f64(expr) as built-in numeric casts parsed through function-call syntax and resolved into cast-specific IR and SQLite plan nodes. Assisted-by: Codex:gpt-5.5
Capture the AST and parser surface needed for built-in numeric cast syntax before implementing function-call parsing. Assisted-by: Codex:gpt-5.5
Add an unresolved function-call AST node and parse IDENT(...) expressions while keeping resolver support closed until built-ins lower to semantic IR. Assisted-by: Codex:gpt-5.5
Add cast value expressions to Semantic IR and lower i64(expr) and f64(expr) function calls in resolver value contexts while preserving unsupported function and arity diagnostics. Assisted-by: Codex:gpt-5.5
Add SQLite plan, SQL generation, and query pipeline coverage for explicit numeric casts lowered from Semantic IR. Assisted-by: Codex:gpt-5.5
Collaborator
Author
|
@codex review |
|
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit numeric cast expressions for
i64(expr)andf64(expr)and lower them through the existing staged query pipeline.Closes #15
Scope
IDENT(...)expressions.CastExprand resolver lowering fori64(expr)andf64(expr).CAST(... AS INTEGER)andCAST(... AS REAL).Spec and plan alignment
List the
spec/andplan/files checked for this change. If the change intentionally diverges from them, explain why and include the required document update in this pull request.spec/query.mdspec/ir.mdspec/sqlite-query-plan.mdplan/query-expression-model-plan.mdTests
List the automated and manual checks performed.
cargo test --workspaceReview notes
Call out API boundaries, temporary rules, migration concerns, or follow-up work that reviewers should inspect closely.
i64(expr)andf64(expr).AI assistance
Disclose AI tool usage according to
AI_POLICY.md.Assisted-bytrailers.Tools and models: