feat: support string query functions#29
Merged
Merged
Conversation
Assisted-by: Codex:gpt-5.5
Assisted-by: Codex:gpt-5.5
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Assisted-by: Codex:gpt-5.5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Add initial query-language support for built-in string value functions.
Closes #17
Scope
concat(...)andstr(expr).concatandstrfunction-call syntax preservation.StringFunctionExprto Semantic IR with argument scalar type and cardinality metadata.concat(...)andstr(expr)with resolver-level arity, type, null, and many-cardinality checks.concatas SQLite||andstr(bool)as a null-awareCASEexpression returningtrue/falsetext.Spec and plan alignment
List the
spec/andplan/files checked for this change. If the changeintentionally diverges from them, explain why and include the required document
update in this pull request.
spec/query.mdspec/ir.mdspec/sqlite-query-plan.mdplan/query-expression-model-plan.mdTests
List the automated and manual checks performed.
cargo test --workspacequery-parser,query-ir,query-resolver,sqlite-query-plan,sqlite-query-sqlgen, andquery-pipeline-tests.Review notes
Call out API boundaries, temporary rules, migration concerns, or follow-up work
that reviewers should inspect closely.
concat(...)is variadic but requires at least twostrarguments.str(expr)is explicit and does not introduce implicit string casts for comparisons, membership checks, arithmetic, or concatenation.str(bool)intentionally renderstrue/falsetext through SQLiteCASEinstead of relying on SQLiteCAST, which would expose1/0text behavior.length,lower,upper,trim,replace,substr, and predicate helpers remain deferred.AI assistance
Disclose AI tool usage according to
AI_POLICY.md.messages with
Assisted-bytrailers.Tools and models: