Skip to content

Add initial eval set#126

Merged
haroonc merged 15 commits intogemini-cli-extensions:evalsfrom
kmontg:main
Apr 10, 2026
Merged

Add initial eval set#126
haroonc merged 15 commits intogemini-cli-extensions:evalsfrom
kmontg:main

Conversation

@kmontg
Copy link
Copy Markdown

@kmontg kmontg commented Apr 10, 2026

Feat: add initial eval set

@kmontg kmontg requested a review from haroonc April 10, 2026 16:04
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive evaluation framework for GCP CI/CD deployments, encompassing Docker configurations, task definitions, and automation scripts for setup and validation. Key feedback identifies several functional issues, including an invalid Terraform version, an incorrect model name, and a configuration error in the Dockerfile that prevents environment variable expansion. Additionally, improvements are suggested to enhance build stability by using a stable base image, removing duplicate environment variables, and increasing evaluation trials for more consistent results.

@haroonc haroonc changed the base branch from main to evals April 10, 2026 16:39
@haroonc haroonc merged commit 2553265 into gemini-cli-extensions:evals Apr 10, 2026
4 checks passed
kmontg added a commit that referenced this pull request Apr 13, 2026
Initial set of evals that will be run offline in a matrix of test repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants