Conversation
abf61ef to
9c2cb44
Compare
stroncod
left a comment
There was a problem hiding this comment.
How are we going to handle IQ in the UI as well. is going to show up old bins or gpp?
| elif cond == GppProgramProvider._ConstraintKeys.IQ: | ||
| if wavelength is not None: | ||
| percentile_iq = Conditions.percentile_iq(value, wavelength, x_max) | ||
| return percentile_iq / 100.0 |
There was a problem hiding this comment.
One thing Claude flagged: percentile_iq might return IQ 0.0 and this would make the observation to get a 0 score, maybe we need to floor this to IQ20?
There was a problem hiding this comment.
Where is that happening, I can't find the place were the score is being computed and uses the IQ. The only place in the selector match_conditions function the IQ is being used to compare and generate a boolean vector based in a comparison (which won't be affected by the 0.0 percentile) and in the adjusted which penalizes if a better than needed conditions are used, in equation the value is 1.0 - value, so a better IQ (lower number) returns a bigger result.
There was a problem hiding this comment.
Yes on match_conditions:
if required_iq = 0.0 that would always be considered bad_iq regardless of the actual condition, actually anything from 0 to 0.19 would be left out as actual_iq is binned at 0.2 . I guess is more than we also need to modify the weather service to reflect on this or just assume something lower than 0.2 is 0.2 for the sake of comparison.
There was a problem hiding this comment.
I think this is more a question for @bryanmiller, my initial guess is having an actual result of 0.0 is not feasible and the values of the zenith_fwhm and wavelength won't allow it.
… won't provide smaller values
stroncod
left a comment
There was a problem hiding this comment.
Changes were already discuss. Left approved for convenience. Thanks for the changes.
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Changelog
feature (GSCHED-1042): Start using ImageQuality as a continuous range instead of bins and keep it retro-compatible
Should resolve the last lucupy PR modifications.
Scope
backend/)frontend/)docs/).github/)Jira
GSCHED-1042
Checklist
changelog.d/feat(backend):,fix(frontend):, etc.)breakingfragment added)