Conversation
44caed4 to
1523b77
Compare
|
This PR requires the gemini-hlsw/lucupy#134 to be approved and merged to regenerate the uv lockfile and then be able to merge this PR. |
| elif constraints.elevation_type == ElevationType.HOUR_ANGLE: | ||
| hourangle_deg = np.degrees(hourangle) | ||
| mask &= (hourangle_deg >= constraints.elevation_min) & (hourangle_deg <= constraints.elevation_max) | ||
| # Hour angle constraints are in hours. |
There was a problem hiding this comment.
This would need a recalculation of the DB as it might yield different results.
There was a problem hiding this comment.
How should we recalculate this info?
Must the current data be manually deleted in order to run the re-calculation or this will be automatically run?
There was a problem hiding this comment.
Manually deleted and recalculated for now. is a bit tricky because what we have in storage now might not be useful and it can get stale safely. I guess is a case to case to check if the program is going to be use. At least for dev as we test with what is available it would be good to recalculate but with Prod I think past aggregated obs might not show up in the future.
|
Tick the box to add this pull request to the merge queue (same as
|
| hourangle_deg = np.degrees(hourangle) | ||
| mask &= (hourangle_deg >= constraints.elevation_min) & (hourangle_deg <= constraints.elevation_max) | ||
| # Hour angle constraints are in hours. | ||
| hourangle_hours = np.degrees(hourangle) / 15.0 | ||
| mask &= (hourangle_hours >= constraints.elevation_min) & (hourangle_hours <= constraints.elevation_max) | ||
| # Within the hour angle limits the airmass is at most the one at the limits, so the equivalent | ||
| # airmass constraint (sky.hour_angle_to_airmass_limits) only adds the airmass cap. | ||
| mask &= airmass <= ElevationLimits.AIRMASS_LIMIT |
There was a problem hiding this comment.
Also, for this change would be good to have @bryanmiller input
This branch has not been deployed
2 participants
Changelog
feature (GSCHED-1043): Parse elevation limit from program providers if possible, otherwise do it when the target information is retrieved for nonsidereal targets. Store the elevation limit inside the Constraints class
Scope
backend/)frontend/)docs/).github/)Jira
Checklist
changelog.d/feat(backend):,fix(frontend):, etc.)breakingfragment added)