Disable magnifier in tree#784
Merged
Merged
Conversation
sonic16x
commented
Jul 20, 2026
sonic16x
commented
Contributor
commit: |
✅ Component tests succeed
|
✅ E2E tests succeed
|
shadowusr
approved these changes
Jul 20, 2026
shadowusr
left a comment
shadowusr
left a comment
Member
There was a problem hiding this comment.
Disabling looks fine to me!
However, currently it only disables the magnifier feature, but doesn't bring much value to the user. I think, in the turned off state, the "diff bubbles" feature should become available. Judging by the code, it should be simple enough to implement — just pass the "diff regions" field for the diff image to component.
Other than that, all good!
added 2 commits
July 20, 2026 17:24
sonic16x
force-pushed
the
disable-magnifier-in-tree
branch
from
July 20, 2026 10:24
4649417 to
14c7bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.