fix: use RAF timing in rrweb snapshots#1103
Merged
Merged
Conversation
shadowusr
commented
Jun 20, 2025
| }); | ||
|
|
||
| // @ts-expect-error | ||
| window.rrweb.record.addCustomEvent("color-scheme-change", { |
Member
Author
There was a problem hiding this comment.
Тут только форматирование изменилось! Надо смотреть только на строки 22-26 и 48-63
commit: |
sipayRT
approved these changes
Jun 20, 2025
KuznetsovRoman
approved these changes
Jun 20, 2025
| window.lastProcessedRrwebEvent = -1; | ||
| // @ts-expect-error | ||
| window.rrwebEvents = []; | ||
| window.__testplaneTiming = { |
Member
There was a problem hiding this comment.
Do we always have "__geminiCore" in our global scope from client-bridge?
If yes, then maybe we should stick to using existing "__geminiCore" instead of creating new variables?
Some of our big projects track extra global variables and would throw error here
Member
Author
There was a problem hiding this comment.
We completely re-write __geminiCore in client bridge. Also, we store time travel snapshots in separate field. I suggest refactoring all of the injected data in a separate PR.
shadowusr
force-pushed
the
users/shadowusr/TESTPLANE-576
branch
from
June 23, 2025 15:39
c0d5173 to
4f3162e
Compare
KuznetsovRoman
pushed a commit
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.