fix: add support for ignoreElements in viewport-mode assertView#1289
Conversation
commit: |
✅ Testplane E2E run succeed
|
✅ Testplane browser-env run succeed
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f67b9c95d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| usePixelRatio?: boolean; | ||
| disableAnimation?: boolean; | ||
| disableHover?: DisableHoverMode; | ||
| ignoreSelectors?: string[]; |
There was a problem hiding this comment.
Why did you decide to name it differently? I mean not ignoreElements. For example, for android, we can pass native locators
There was a problem hiding this comment.
It's not public API, it's an internal options object, so we can change this any time. It's consistent with this field:
For example, for android, we can pass native locators
Hmm, I doubt that will work currently. Right now we only work with css selectors in assertView. But yeah, in the future we could support that. In that case, we can always rename it
3 participants
What's done?
ignoreSelectorsin assertView viewport mode (e.g.assertView('state-name', { ignoreElements: ['#ignore'] }))