Skip to content

feat: support assertView calls on any valid webdriver element#1293

Merged
shadowusr merged 2 commits into
masterfrom
users/shadowusr/TESTPLANE-1066
Jul 16, 2026
Merged

feat: support assertView calls on any valid webdriver element#1293
shadowusr merged 2 commits into
masterfrom
users/shadowusr/TESTPLANE-1066

Conversation

@shadowusr

Copy link
Copy Markdown
Member

What's done?

The idea:

  • Originally, we extracted element.selector in assertView and then tried to find element using this selector
  • This PR makes it so that we pass the precise element description object to the browser side (which required some refactoring of client-bridge), which makes possible to use any valid webdriverio selector, e.g. >>>.lable (for shadow dom), div*=Some text (for webdriverio-style text based selectors) or testing-library selectors

On client side, I've also migrated all places that were quering page for elements to use single lib.query* methods, that support xpath selectors.

@pkg-pr-new

pkg-pr-new Bot commented Jul 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/gemini-testing/testplane@1293

commit: 32815d7

@github-actions

Copy link
Copy Markdown

✅ Testplane E2E run succeed

Report

@github-actions

Copy link
Copy Markdown

✅ Testplane browser-env run succeed

Report

@shadowusr
shadowusr merged commit 7af78c5 into master Jul 16, 2026
9 checks passed
@shadowusr
shadowusr deleted the users/shadowusr/TESTPLANE-1066 branch July 16, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants