Skip to content

Fix INI description parsing dropping descriptions containing "word=" #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritchiecarroll merged 1 commit into from
Jun 8, 2026
Merged

Fix INI description parsing dropping descriptions containing "word=" #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Gemstone/Configuration/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,11 @@ public static void UpdateInstance(Settings settings)
Instance = settings;
}

private const string INIKeyValuePairPattern = @";?\s*(?<key>\w+)\s*=.*";
// Anchored at the start of the line so a description comment that merely *contains* a "word="
// sequence (e.g. "...is set to Enabled=false in the database...") is not misinterpreted as a
// key/value pair. Without the leading '^', Regex.Match scans the whole line and matches the
// embedded "Enabled=false", which causes the real description above the setting to be dropped.
private const string INIKeyValuePairPattern = @"^;?\s*(?<key>\w+)\s*=.*";
private static readonly Regex s_iniKeyValuePair;

static Settings()
Expand Down
Loading