Add AlarmMeasurement.ShardID for day-sharded event details#62
Open
ritchiecarroll wants to merge 2 commits into
Open
Add AlarmMeasurement.ShardID for day-sharded event details#62ritchiecarroll wants to merge 2 commits into
ritchiecarroll wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
AlarmMeasurement.ShardIDproperty used by openHistorian's new day-sharded event-details storage. This is a small, additive, foundational change; the rest of the feature lives in the SnapDB and openHistorian repositories (see Related PRs).What changed
AlarmMeasurement.ShardID(ushort) — identifies the day-based shard that holds the alarm's event details.0indicates no associated event details.usingdirectives in adapter/model files (no behavior change).Why
openHistorian encodes this shard identifier into the archived
HistorianValueand uses it to locate the correct per-day SQLite database that stores the alarm's event details. Without a carrier on the measurement, the cleared record (archived under the clear-day timestamp) could not point back to the raise-day shard.Reviewer / tester considerations
0; existing alarm flows are unaffected unlessShardIDis explicitly set (which only openHistorian'sAlarmEnginedoes).Developmentbuilds consume this via theGemstone.TimeseriesNuGet package, so this must be published before those builds can pick up the feature.Development-configuration builds reference the project directly.Testing
Exercised indirectly by openHistorian's event-details unit tests (the alarm write path sets and round-trips
ShardID). No new tests in this repo given the change is a single additive property.Related PRs
This change is part of an event-details feature spanning three repositories: