Skip to content

Validate the types of adapters loaded by AdapterCollectionBase #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenCWills wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Validate the types of adapters loaded by AdapterCollectionBase #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Gemstone.Timeseries/Adapters/AdapterCollectionBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,12 @@ public virtual bool TryCreateAdapter(DataRow adapterRow, out T adapter)
throw new InvalidOperationException("Specified adapter assembly does not exist");

Assembly assembly = Assembly.LoadFrom(assemblyName);
adapter = (T)Activator.CreateInstance(assembly.GetType(typeName)!)!;
Type? adapterType = assembly.GetType(typeName);

if (!typeof(T).IsAssignableFrom(adapterType))
throw new InvalidOperationException("Adapter type is not compatible with the adapter collection");

adapter = (T)Activator.CreateInstance(adapterType)!;

// Assign critical adapter properties
adapter.Name = name;
Expand Down