Conversation
1. Store scan address names as "<provider> Permit2" and "<provider> Router" so the spender row tells Uniswap's Permit2 apart from its Universal Router instead of showing "Uniswap" for both. 2. Upsert the names on the (chain, address) key so a rename reaches rows already in the database on the next setup run; the fraud and verification flags stay untouched. 3. Tag the static THORChain and Maya routers, Chainflip vaults, NEAR Intents treasuries, Mayan contracts and the Squid multicall with their chain at the source, so the provider and the setup step read one table. 4. Add those addresses and the Across multicall handlers under the provider name, so history and confirmation rows show "THORChain" or "Chainflip" instead of a raw address. EVM contracts deployed at one address on every chain sit under Ethereum; the address name lookup already falls back across chains.
gemcoder21
reviewed
Sep 16, 2026
1. Insert the scan address names with on-conflict-do-nothing instead of upserting, so a setup run no longer bumps updated_at on every row it already knows. 2. Drop the upsert path from the store and repository since nothing else calls it.
0xh3rman
marked this pull request as ready for review
September 17, 2026 23:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1036, new Permit2 approvals look consistent (EIP712 and normal ERC20 Approve), our contract labeling shows both Uniswap (address), one of them is Permit2, another one is Router, this pr adds our known swapper contracts to scan address DB
Changes: