Skip to content

Conversation

@YuWei-CH
Copy link
Collaborator

  1. Add a check_files_not_empty() in job.py to ensure that user uploaded file is not empty
  2. I would like to suggest that, regardless of whether we succeed or not, we should keep the upload folder. While reform.py can run successfully, there is a very small chance that the user might still get an incorrect result due to potential bugs in reform.py. If you believe this possibility can be safely ignored, I will update the code to remove the upload folder when the process completes successfully.

@YuWei-CH YuWei-CH requested a review from genericdata October 23, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants