Repository navigation
Assemble fake credentials in tests instead of writing them out - #55
Merged
Merged
Conversation
…5; done; gh pr checks 55 2>&1 | tail -1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub secret scanning flagged an OpenAI key in
test/redact-secrets.test.ts. It is a fabricated string with no account behind it, so there is nothing to rotate — but the alert is the scanner doing its job, and dismissing it is the wrong habit. The fixture corpus was already base64 for this reason; leaving a matching literal in the test beside it was inconsistent.The fake credentials are now assembled from parts at runtime. Same values, same coverage, nothing in the source that matches a scanner.
87 tests pass.
https://claude.ai/code/session_01NZDHk4yVYP4jMZkTUMQ1Lw