Write down the title-writer invariant where it is enforced - #62
Merged
Merged
Conversation
sessions.title has exactly two writers: setTitle fills an empty title so a later, worse guess cannot clobber a good one, and renameStmt overwrites for a harness that names a session after the fact. Both mask, which makes the split the security boundary as well as the correctness rule - an adapter reaching for the column directly bypasses redaction, and one did until v0.12.5. Comment only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZDHk4yVYP4jMZkTUMQ1Lw
gengwg
added a commit
that referenced
this pull request
Sep 8, 2026
Write down the title-writer invariant where it is enforced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment only, no behaviour change.
The reviewer's closing point was that the
setTitle/renameSessionsplit is now both the correctness rule (a later, worse guess must not clobber a good title) and the security boundary (both mask, and an adapter reaching for the column directly bypasses redaction — which one did until v0.12.5). That invariant was not written down anywhere; it now sits above the two statements that enforce it.93 tests pass.
https://claude.ai/code/session_01NZDHk4yVYP4jMZkTUMQ1Lw