Skip to content

fix: Windows genlayer up, localhost access, cross-platform CI#288

Merged
MuncleUscles merged 3 commits intomainfrom
fix/windows-and-localhost-access
Mar 27, 2026
Merged

fix: Windows genlayer up, localhost access, cross-platform CI#288
MuncleUscles merged 3 commits intomainfrom
fix/windows-and-localhost-access

Conversation

@MuncleUscles
Copy link
Copy Markdown
Member

Summary

  • Fix Windows genlayer up (#1548): Remove detached start cmd.exe wrapper that caused ECONNREFUSED. The old command launched a separate cmd window and returned immediately, so the CLI tried to ping :4000 before docker compose even started. Now runs directly with -d flag, with quoted paths for spaces.
  • Enable localhost access by default: Generates docker-compose.override.yml and config-overrides/genvm-module-web.yaml on every genlayer up/init, allowing GenVM contracts to reach host services (Anvil, local APIs) via host.docker.internal. Prints a warning.
  • Add docker-compose.yml to npm package files: Was missing — the compose file wasn't included in the published package.
  • Cross-platform CI: Matrix strategy (ubuntu, macos, windows) for the CI workflow.
  • Platform command tests: Unit tests for command generation across all 3 platforms and setupLocalhostAccess.

Test plan

  • All 491 existing + new tests pass locally
  • CI passes on ubuntu, macos, windows matrix
  • Manual test on Windows: npm install -g genlayer && genlayer up should start containers

Closes #1548

Swap quote nesting in node -p command — outer single quotes,
inner double quotes — so bash doesn't consume the escapes.
- Fix Windows `genlayer up` failing with ECONNREFUSED (#1548): remove
  detached `start cmd.exe` wrapper, quote paths for spaces, use -d flag
- Enable localhost access by default: generate docker-compose.override.yml
  and genvm-module-web.yaml so GenVM can reach host services (Anvil, etc.)
- Add docker-compose.yml to npm package files (was missing)
- Add cross-platform CI matrix (ubuntu, macos, windows)
- Add unit tests for platform commands and localhost access setup
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Warning

Rate limit exceeded

@MuncleUscles has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 11 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 27 minutes and 11 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7bd7a005-5730-4dc6-a424-3fb7d5c3bb80

📥 Commits

Reviewing files that changed from the base of the PR and between f022b3b and 3eb6994.

📒 Files selected for processing (13)
  • .github/workflows/cli-docs.yml
  • .github/workflows/validate-code.yml
  • package.json
  • src/commands/general/init.ts
  • src/commands/general/start.ts
  • src/lib/config/simulator.ts
  • src/lib/interfaces/ISimulatorService.ts
  • src/lib/services/simulator.ts
  • tests/actions/init.test.ts
  • tests/actions/start.test.ts
  • tests/libs/configFileManager.test.ts
  • tests/libs/platformCommands.test.ts
  • tests/services/simulator.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-and-localhost-access

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tests hardcoded Unix-style paths (/mocked/home/.genlayer) but
path.resolve produces backslash paths on Windows. Use path.resolve
for expected values so tests pass on all platforms.
@MuncleUscles MuncleUscles merged commit debaa49 into main Mar 27, 2026
5 checks passed
@MuncleUscles MuncleUscles deleted the fix/windows-and-localhost-access branch March 27, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant