fix: Windows genlayer up, localhost access, cross-platform CI#288
fix: Windows genlayer up, localhost access, cross-platform CI#288MuncleUscles merged 3 commits intomainfrom
Conversation
Swap quote nesting in node -p command — outer single quotes, inner double quotes — so bash doesn't consume the escapes.
- Fix Windows `genlayer up` failing with ECONNREFUSED (#1548): remove detached `start cmd.exe` wrapper, quote paths for spaces, use -d flag - Enable localhost access by default: generate docker-compose.override.yml and genvm-module-web.yaml so GenVM can reach host services (Anvil, etc.) - Add docker-compose.yml to npm package files (was missing) - Add cross-platform CI matrix (ubuntu, macos, windows) - Add unit tests for platform commands and localhost access setup
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 27 minutes and 11 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tests hardcoded Unix-style paths (/mocked/home/.genlayer) but path.resolve produces backslash paths on Windows. Use path.resolve for expected values so tests pass on all platforms.
Summary
genlayer up(#1548): Remove detachedstart cmd.exewrapper that caused ECONNREFUSED. The old command launched a separate cmd window and returned immediately, so the CLI tried to ping:4000before docker compose even started. Now runs directly with-dflag, with quoted paths for spaces.docker-compose.override.ymlandconfig-overrides/genvm-module-web.yamlon everygenlayer up/init, allowing GenVM contracts to reach host services (Anvil, local APIs) viahost.docker.internal. Prints a warning.docker-compose.ymlto npm packagefiles: Was missing — the compose file wasn't included in the published package.setupLocalhostAccess.Test plan
npm install -g genlayer && genlayer upshould start containersCloses #1548