Repository navigation
fix: preserve runtime network identity - #111
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
studio_devnetpreset (chain 61997,https://studio-dev.genlayer.com/api)chainId, so Transaction Kit can reject stale or wrong-network suggestionsgenlayer-py==0.19.0rc2floor and document localnet 61127 / hosted preview 61997Why
The prior configuration parser accepted network
idvalues but silently ignored overrides for built-in networks, andGeneralConfig.get_chain()returned the untouched SDK preset for custom networks. That can sign a transaction for a different chain than the selected RPC endpoint and surface asInvalidChainId. Fee profiles also lacked numeric network provenance, which allowed stale profiles to be reused on another chain.Fast regression coverage
studio_devnetand custom Studio identity without mutating global SDK presetschainIdround-trips in JSONValidation
gltest tests/gltest_cli/ -q— 73 passedgltest tests/gltest/ -q— 41 passedgltest tests/glsim/ -q— 72 passedgltest tests/gltest_direct/test_sdk_loader.py -q— 12 passedpytest tests/test_release_version.py -q— 14 passeduv lock --checkRelease target after merge:
genlayer-test==0.30.0rc1.