Repository navigation
fix(fees): flatten allocation inputs and correct executor funding 🐛 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
Repository: genlayerlabs/genvm-executor
Length of output: 8661
🏁 Script executed:
git diff --unified=25 75e4d1fd5945aadea065f6928e60155ffca63797 cb1453dca3c8c1b589b0c3b5237e1cc3a3377e7f -- executor/src/lib.rs rg -n 'MessageAllocationNode|children_budget|subtree|convert_message_allocation_node' executorRepository: genlayerlabs/genvm-executor
Length of output: 6606
🏁 Script executed:
Repository: genlayerlabs/genvm-executor
Length of output: 18359
🌐 Web query:
https://github.com/genlayerlabs/genvm-manager/pull/45 allocation children_budget subtree node producer💡 Result:
🏁 Script executed:
Repository: genlayerlabs/genvm-executor
Length of output: 2343
🌐 Web query:
genlayer_calldata Decode struct missing fields genvm modules-interfaces MessageAllocationNode children_budget subtree💡 Result:
🏁 Script executed:
Repository: genlayerlabs/genvm-executor
Length of output: 28989
🏁 Script executed:
Repository: genlayerlabs/genvm-executor
Length of output: 10016
Coordinate the node producer before deploying the new allocation schema.
executor/src/exe/run.rs:125decodes execution bytes intogenvm_modules_interfaces::ExecutionData. The allocation converter now expectschildren_budgetandsubtreeinstead of recursivechildren. If the node still sends the v0.3 recursive allocation format, the typed decoder can rejectchildrenas an unknown field or report the new fields as missing. Update the node to send the direct-child budget inchildren_budgetand the subtree bytes required by the transaction's pinned storage mode before pinning this executor.🤖 Prompt for AI Agents