Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GenVM PR actionsTick a box to run it (the box unticks itself when handled). Actions only run while the PR has the
Commands
|
- Walk the whole error chain for `BudgetExhausted`, including `CallbackError`, `BadArgument`, `WithContext` and the `Arc`s `scripting::call_fn` unwraps to - Cover a `pcall` rethrow, both `call_fn` shapes and an unrelated callback error
kp2pml30
changed the base branch from
v0.6-dev
to
feat/message-fee-allocations
September 29, 2026 04:55
kp2pml30
force-pushed
the
handoff/llm-budget-callback-timeout-1692
branch
from
September 29, 2026 04:55
3201b08 to
cc35474
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pinned manager at
89c20400f77b647b0e7649f58be0212a4bd6f004catches a directBudgetExhaustederror but misses theCallbackErrorwrapper that a real Luallm.exhaust()callback produces. The LLM handler then returns a module failure instead of the timeout sentinel consumed by the executor.This draft adds a focused expected-red unit test. It leaves the production matcher unchanged for the manager owner to repair.
Evidence and validation
CallbackError { cause: ExternalError(BudgetExhausted) }shape, and checks that both direct and wrapped errors becomeconsumed_gen = U256::MAX. The direct control passes; the wrapped assertion currently fails withINSUFFICIENT_EXECUTION_BUDGET.InternalErrorwith a working provider and genuine low user allocation against exact consensus #1692. The node fallback still sent a semantically correctTimeoutvote and the chain storedLeaderTimeout; no chain revert or idleness sanction is claimed.The manager
v0.6-devbranch was exactly at the pinned revision when this branch was cut. Open manager #45 changes fee input structures but not this handler; no open manager PR changesimplementation/src/llm/handler.rsor this test. No executor gitlink, dependency pin, production code, full E2E, or merge is changed here.