Fix bootstrapCD: CDROOT_TYPE parameter should not be modified in the loop.#64
Open
rgiuse wants to merge 1 commit intogentoo:masterfrom
Open
Fix bootstrapCD: CDROOT_TYPE parameter should not be modified in the loop.#64rgiuse wants to merge 1 commit intogentoo:masterfrom
rgiuse wants to merge 1 commit intogentoo:masterfrom
Conversation
when determine_fs don't found the fs type of device return the last input value ( last valid once ) and not the original parameter. So the mount can fail. mount command success exit code are: success 0 partial success 64 we need test the mount in any case. modified: defaults/initrd.scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually the function determine_fs return the last valid filesystem type was mounted, instead of the original requested parameter, when it fails to detect the device’s actual filesystem type.
That can cause mount to be called with the wrong -t value.
We need use a temp variables and preserve the original filesystem type parameter.
Successful or partial successful mount exit codes:
0 → success
64 → partial success
Therefore, you need to test the mount result, in both cases.