Skip to content

PB-2064: Fix Import Tool File Test #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pakb merged 13 commits into from
Jan 22, 2026
Merged

PB-2064: Fix Import Tool File Test #1544

pakb merged 13 commits into from
Jan 22, 2026

Conversation

@ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Dec 24, 2025 •
edited by github-actions bot
Loading

Test link

@github-actions github-actions bot added the bug label Dec 24, 2025
@ismailsunni ismailsunni force-pushed the fix-pb-2064-import-tool-file branch from 0caebb2 to 765ba6f Compare December 25, 2025 02:12
@ismailsunni ismailsunni requested a review from pakb December 31, 2025 15:14
pakb
pakb reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have some rebase work to do, as it looks like you were based on your "fix build" branch which is now merged in the Pinia branch

@ismailsunni ismailsunni force-pushed the fix-pb-2064-import-tool-file branch from 765ba6f to 389d00d Compare January 12, 2026 03:33
@cypress
Copy link

cypress bot commented Jan 12, 2026 •
edited
Loading

web-mapviewer    Run #6413

Run Properties:  status check failed Failed #6413  •  git commit 0e6575363e: PB-2064: fix GPX/KML parsing in e2e test
Project web-mapviewer
Branch Review fix-pb-2064-import-tool-file
Run status status check failed Failed #6413
Run duration 19m 47s
Commit git commit 0e6575363e: PB-2064: fix GPX/KML parsing in e2e test
Committer Pascal Barth
View all properties for this run ↗︎
Test results
Tests that failed  Failures 24
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 6
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 235
View all changes introduced in this branch ↗︎

Tests for review

Failed  drawing.cy.ts • 13 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Screenshots
Drawing module tests > Drawing mode/tools > can create line / measurement, extend it, and delete the last node by right click / button, and make a polygon Screenshots
Drawing module tests > Drawing mode/tools > can create line/polygons and edit them Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL Screenshots
Drawing module tests > KML management > receives an empty KML and can use drawing mode Screenshots
Drawing module tests > others > can export the drawing/profile in multiple formats Screenshots
The first 10 failed tests are shown, see all 13 tests in Cypress Cloud.
Failed  legacyParamImport.cy.ts • 5 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param Test Replay Screenshots
Test on legacy param import > Layers import > don't keep KML adminId in URL after import Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers Test Replay Screenshots
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL only heading Test Replay Screenshots
... > Select a few features and shows the tooltip in its correct spot Test Replay Screenshots
Failed  featureSelection.cy.ts • 4 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Testing the feature selection > Feature pre-selection in the URL > Synchronise URL and feature selection Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select an area to identify features inside it Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select feature by click, add more feature, and deselect feature Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can print feature information Test Replay Screenshots
Failed  importToolMaps.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
The Import Maps Tool > Import external WMTS layers Test Replay Screenshots
Failed  print.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
Testing print > Send print request with external layers > prints external WMTS correctly Test Replay Screenshots

@ismailsunni ismailsunni force-pushed the fix-pb-2064-import-tool-file branch from a8f7de7 to 210c200 Compare January 13, 2026 04:32
@ismailsunni ismailsunni requested a review from pakb January 13, 2026 06:00
pakb
pakb reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to double check the CI, the file you want to fix did not go through successfully

@ismailsunni ismailsunni force-pushed the fix-pb-2064-import-tool-file branch 3 times, most recently from 879bf28 to f50abec Compare January 20, 2026 07:21
@ismailsunni ismailsunni force-pushed the fix-pb-2064-import-tool-file branch from f50abec to ab0414d Compare January 21, 2026 08:21
@pakb pakb force-pushed the fix-pb-2064-import-tool-file branch 2 times, most recently from fb22fa0 to 28b73f6 Compare January 22, 2026 13:56
pakb added 4 commits January 22, 2026 15:14
@pakb
PB-2064: externalize @swissgeo/log in all packages
40e7abe 
This way the settings we have in the viewer is applied to all packages (as they will be using the same instance of @swissgeo/log as the viewer), enabling us to have debugging logs in libraries while developing on the viewer
@pakb
PB-2064: fix issue with GPX parsing
ba02c9b 
testing with `instanceof` is not working as expected between libs, as the instance might not be the "exact same"

Adding the possibility to give loadedContent to file parser as string (useful in the case of GPX parsing)
@pakb
PB-2064: add zoom-to-extent button for GPX
31b3751
@pakb
PB-2064: fix GPX/KML parsing in e2e test
0e65753
@pakb pakb force-pushed the fix-pb-2064-import-tool-file branch from 28b73f6 to 0e65753 Compare January 22, 2026 14:18
@pakb pakb merged commit 7c3e859 into feat-PB-1383-pinia-store Jan 22, 2026
3 checks passed
@pakb pakb deleted the fix-pb-2064-import-tool-file branch January 22, 2026 14:18
@ismailsunni
Copy link
Contributor Author

ismailsunni commented Jan 23, 2026

thanks @pakb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pakb pakb pakb left review comments

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ismailsunni @pakb