Skip to content

fix: build DAO publish proposals locally - #1752

Closed
jwalkingjew wants to merge 1 commit into
masterfrom
fix/member-publish-proposal
Closed

jwalkingjew wants to merge 1 commit into
masterfrom
fix/member-publish-proposal

Conversation

@jwalkingjew

Copy link
Copy Markdown
Collaborator

Summary

  • replace the DAO publish path's SDK all-in-one proposal builder with local governance calldata encoding
  • keep SDK IPFS edit upload, then submit the proposal through the app's SpaceRegistry proposal shape
  • normalize publish IDs and explicitly require centralized member/editor access before proposing
  • add coverage for slow member proposals and fast editor proposals

Investigation notes

  • confirmed the affected personal space is a member, not an editor, of Crypto
  • simulated a slow PROPOSAL_CREATED call from that personal space into Crypto on testnet; membership itself is accepted on-chain
  • this PR focuses on the client publish construction/submission path, which matches the screen-recording symptom after access succeeded

Verification

  • env TMPDIR=/private/tmp mise exec -- bun run test core/utils/contracts/publish-proposal.test.ts core/utils/contracts/space-topic.test.ts core/hooks/use-access-control.test.tsx
  • env TMPDIR=/private/tmp mise exec -- bunx eslint core/hooks/use-publish.ts core/utils/contracts/publish-proposal.ts core/utils/contracts/publish-proposal.test.ts core/utils/contracts/space-registry.ts
  • env TMPDIR=/private/tmp NEXT_PUBLIC_APP_ENV=production NEXT_PUBLIC_PRIVY_APP_ID=clpsvsqpt005fl70fe775owo5 NEXT_PUBLIC_GEOGENESIS_RPC=https://test.example.com NEXT_PUBLIC_GEOGENESIS_RPC_TESTNET=https://test.example.com NEXT_PUBLIC_API_ENDPOINT=https://test.example.com NEXT_PUBLIC_API_ENDPOINT_TESTNET=https://test.example.com NEXT_PUBLIC_BUNDLER_RPC=https://test.example.com NEXT_PUBLIC_BUNDLER_RPC_TESTNET=https://test.example.com NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID=a NEXT_PUBLIC_PIMLICO_API_KEY=a mise exec -- bun run build

@vercel

vercel Bot commented May 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
geogenesis Ready Ready Preview May 1, 2026 9:53pm

Request Review

@ohohoreilly

Copy link
Copy Markdown
Contributor

Closing as part of a sweep of the open-PR queue. Not a judgement on the work — reopen if you still want it and I will help get it current.

Opened 2026-05-01 and now conflicting with master. At this distance a rebase is usually more work than redoing the change against current code, and the surrounding code has moved a long way underneath "fix: build DAO publish proposals locally".

@jwalkingjew — if the idea still stands but the branch does not, a fresh PR or a ticket is probably a better route than reviving this one.

Nothing is discarded: the branch and its history remain, and reopening costs a click.

Context: 74 PRs were open, 25 older than two months, the oldest from February. The point is to make the queue mean something so genuinely ready work is visible rather than buried — #2449 sat ready for three days this week partly because of the noise. Only non-draft, conflicting PRs are in scope; drafts and anything still mergeable are being left alone.

This branch was successfully deployed

1 active deployment
Preview — 9093c0f6 Deployed May 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants