Repository navigation
fix(editor): allow external URL links in block content - #1754
jwalkingjew wants to merge 1 commit into
Conversation
PR #1355 made external (http/https) URLs render as inert spans in browse mode. Restore them as real anchors that open in a new tab, while keeping graph:// links as same-page in-app navigation (unchanged).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Closing as part of a sweep of the open-PR queue. Not a judgement on the work — reopen if you still want it and I will help get it current. Opened 2026-05-04 and now conflicting with master. At this distance a rebase is usually more work than redoing the change against current code, and the surrounding code has moved a long way underneath "fix(editor): allow external URL links in block content". @jwalkingjew — if the idea still stands but the branch does not, a fresh PR or a ticket is probably a better route than reviving this one. Nothing is discarded: the branch and its history remain, and reopening costs a click. Context: 74 PRs were open, 25 older than two months, the oldest from February. The point is to make the queue mean something so genuinely ready work is visible rather than buried — #2449 sat ready for three days this week partly because of the noise. Only non-draft, conflicting PRs are in scope; drafts and anything still mergeable are being left alone. |
Summary
target=\"_blank\" rel=\"noopener noreferrer\").graph://links keep their existing same-page in-app navigation (intercepted by the document-level click handler ineditor.tsx).Web2URLMark) and the server-rendered markdown path (renderMarkdownDocument/markdownToRenderedHtml) so SSR and CSR behave the same.Edit-mode rendering is unchanged — markdown text editing UX from #1355 (mention/link insertion, hover tooltips, parsing) is preserved.
Test plan
markdown-renderandmarkdown-adapterrender tests asserttarget=\"_blank\"on https anchors and absence ongraph://anchors[example](https://example.com)in a text block is clickable in browse mode and opens in a new tabgraph://link still navigates in-app, same tabtarget=\"_blank\"