Skip to content

fix(editor): allow external URL links in block content - #1754

Closed
jwalkingjew wants to merge 1 commit into
masterfrom
fix/allow-external-links-in-blocks
Closed

jwalkingjew wants to merge 1 commit into
masterfrom
fix/allow-external-links-in-blocks

Conversation

@jwalkingjew

Copy link
Copy Markdown
Collaborator

Summary

  • Reverts the specific portion of Feat: add link handling in text blocks #1355 that disallowed clickable external URLs in text-block content. External (http/https) links now render as real anchors that open in a new tab (target=\"_blank\" rel=\"noopener noreferrer\").
  • Internal graph:// links keep their existing same-page in-app navigation (intercepted by the document-level click handler in editor.tsx).
  • Affects both the client TipTap browse-mode renderer (Web2URLMark) and the server-rendered markdown path (renderMarkdownDocument / markdownToRenderedHtml) so SSR and CSR behave the same.

Edit-mode rendering is unchanged — markdown text editing UX from #1355 (mention/link insertion, hover tooltips, parsing) is preserved.

Test plan

  • Unit: markdown-render and markdown-adapter render tests assert target=\"_blank\" on https anchors and absence on graph:// anchors
  • Manual: external [example](https://example.com) in a text block is clickable in browse mode and opens in a new tab
  • Manual: same content in edit mode still renders the markdown source string with the existing edit-mode styling
  • Manual: graph:// link still navigates in-app, same tab
  • Manual: SSR — first paint of an entity page with an external link produces an anchor with target=\"_blank\"

PR #1355 made external (http/https) URLs render as inert spans in browse
mode. Restore them as real anchors that open in a new tab, while keeping
graph:// links as same-page in-app navigation (unchanged).
@vercel

vercel Bot commented May 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
geogenesis Ready Ready Preview May 4, 2026 9:31pm

Request Review

@ohohoreilly

Copy link
Copy Markdown
Contributor

Closing as part of a sweep of the open-PR queue. Not a judgement on the work — reopen if you still want it and I will help get it current.

Opened 2026-05-04 and now conflicting with master. At this distance a rebase is usually more work than redoing the change against current code, and the surrounding code has moved a long way underneath "fix(editor): allow external URL links in block content".

@jwalkingjew — if the idea still stands but the branch does not, a fresh PR or a ticket is probably a better route than reviving this one.

Nothing is discarded: the branch and its history remain, and reopening costs a click.

Context: 74 PRs were open, 25 older than two months, the oldest from February. The point is to make the queue mean something so genuinely ready work is visible rather than buried — #2449 sat ready for three days this week partly because of the noise. Only non-draft, conflicting PRs are in scope; drafts and anything still mergeable are being left alone.

This branch was successfully deployed

1 active deployment
Preview — 984ccc94 Deployed May 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants