Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Property groups are an advanced feature, so showing a prominent "Property groups" section while setting up a new type entity added noise to the common case. Remove the standalone header and only render the groups editor once a group exists. Group creation now lives in the property "+" menu (New property / New property group) via a shared useCreatePropertyGroup hook, with a focus atom coordinating auto-focus across page sections.
371dbc1 to
99e3f2b
Compare
There was a problem hiding this comment.
Pull request overview
This PR reduces UI noise on type entities by hiding the property-groups editor until at least one group exists, and moving group creation into the “+” property control via a shared creation hook and cross-section autofocus coordination.
Changes:
- Hide the type property-groups editor entirely when no groups exist; remove the standalone “Property groups” header/controls.
- Add a “+” menu for type entities that offers “New property” and “New property group”.
- Introduce
useCreatePropertyGroupand a sharedfocusPropertyGroupNameAtomto create groups and autofocus the new group name field across sections.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/web/partials/entity-page/type-property-groups-editor.tsx | Removes the prominent groups header and renders the groups editor only once groups exist; switches name autofocus coordination to a shared atom. |
| apps/web/partials/entity-page/editable-entity-page.tsx | Adds a type-entity “+” menu that includes property-group creation and swaps into property search for new properties. |
| apps/web/core/hooks/use-create-property-group.ts | New hook encapsulating creation of property groups on a type entity and triggering shared autofocus. |
| apps/web/atoms/index.ts | Adds focusPropertyGroupNameAtom to coordinate autofocus across page sections. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| placeholder="Find or create property..." | ||
| onDone={onSelectProperty} | ||
| onCreateEntity={onCreateProperty} | ||
| variant="floating" | ||
| advanced={false} | ||
| showIDs={false} | ||
| /> |
|
Closing as part of a sweep of the open-PR queue — not a judgement on the work, and please reopen if you still want it. Opened 2026-06-11, and it now conflicts with master. At this distance a rebase is usually more work than redoing the change against current code, and the property menu has almost certainly moved underneath it. @b-d055 — if this is still wanted, reopen it and I will help get it current. If the idea still stands but the branch does not, it is probably worth a fresh PR or a ticket rather than reviving this one. Context: there are 60 open PRs, 10 older than two months. The intent is to make the queue mean something, so that genuinely ready work is visible instead of buried — #2449 sat ready for three days this week partly for that reason. Nothing here is being discarded: the branch and its history stay, and reopening costs a click. |
Property groups are an advanced feature, so showing a prominent "Property groups" section while setting up a new type entity added noise to the common case. Remove the standalone header and only render the groups editor once a group exists. Group creation now lives in the property "+" menu (New property / New property group) via a shared useCreatePropertyGroup hook, with a focus atom coordinating auto-focus across page sections.