fix(debates): claim the recordings key after reading the URLs, not before (GEO-2950)

[ohohoreilly]

Follow-up to #2449, which merged as a8b83f69. It removed a permanent Loading…; this closes a narrower version of the same bug that the fix left behind.

The gap

#2449 changed the effect to claim fetchedForRef only once URLs are committed, instead of up front. Correct, but the claim still lands one line before the values are read:

fetchedForRef.current = recordingsKey;
setUrls({ slot1: slot1Result.url, slot2: slot2Result.url });

geoChatRequest returns undefined on a 204 (core/debates/api.ts:1642), so slot1Result.url is a TypeError rather than a rejected request. It throws after the claim and lands in the .catch, which deliberately does not release — so the key stands over null URLs. The card shows its error, and every later activation takes the fetchedForRef.current === recordingsKey early return and never asks again.

That is the permanent Loading… #2449 set out to remove, reached through a narrower door. The .catch comment — "The key was never claimed" — is true for a rejected request and false for this.

The fix

Read both fields before claiming. That makes "never claimed" true for every throw that can reach the catch, and needs nothing else.

Deliberately not fixed by releasing in the .catch. That is what the code did before #2449, and because the key is identical across attempts, it let a stale cancelled attempt free a claim a newer in-flight one owned — the original defect. The catch stays exactly as it is, now with a comment saying why, so this does not get "tidied" back into the old bug.

Test

Drives a 204-shaped answer, then scrolls away and back, and asserts the card asks again rather than latching.

I checked that it bites rather than assuming: reverted to the previous ordering and the test fails; restored it and it passes. A regression test that passes without the fix is worth nothing.

Verification

105 files / 1612 tests pass across core/debates; tsc clean on the touched file.

Context

Found while reviewing #2449, reported there as a medium finding, and merged before it was addressed — so it is live on master now. Related to GEO-2950, where the permanent-grey user report sits.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
geogenesis	Ready	Preview	Sep 20, 2026 1:41am UTC