Conversation
- The title (entityTitle), type/tag chips and the verdict form one block above the tabs, with Agree/Disagree inside the verdict and no card border or padding. 48px between the chips, the verdict and the tabs. - The percentage uses mainPage in the text colour; 12px above the bar, 8px below it, and no swatch dots on the sides row. - Controversial is a red chip beside the type and tag chips, in the chips' own size and type. - The responder list is titled "6 people agree" above the rows, puts people with a profile picture first, and highlights rows on hover like the browse sidebar. - The Debates tab lets a debate fill the content column. - Brings in the Activity section header from #2514 (pills, View all, header arrows, 12px compact player corners). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… add a Topics tab - The hero is the Explore claim card at page scale: the claim and its Agree/Disagree pills on the left, Explore's own 220px verdict column on the right behind a full-height rule, starting level with the title. Under a 520px container it stacks, as the card does. A claim nobody has answered takes the full width. - ClaimVerdictColumn is exported from the Explore card for this; the page's own ClaimVerdict is removed, since nothing else used it. - The title and the verdict's type go back to their original sizes; the type and tag chips are gone, and Controversial sits above the title. - Topics move to a Topics tab (/topics), listed uncapped. The hero's capped topic row is built but off (SHOW_HERO_TOPICS), and the Overview no longer repeats them. - The page column is 840px, for 800px of content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…e the verdict moved to Explore's column Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Closing this as superseded by #2530, which carries this work forward rather than replacing it. #2530 started as a branch on top of Two things changed in the move, both worth knowing about: The Activity-header conflict is resolved in favour of what merged. This PR took the Activity header from #2514's branch, noting that "whichever of the two PRs merges second will have nothing to do in these files". #2514 merged on Three findings from a review of the combined branch are fixed on #2530, all in code from this PR:
The hero, the responder-list changes, the |
… make Topics a ranked explore feed (#2530) Supersedes #2526, whose commits this carries; the claim hero is o-p-o-p-o's work and design. ## The claim hero The Explore claim card's layout at page scale: the claim, its description and the Agree/Disagree pills on the left, Explore's 220px verdict column on the right behind a full-height rule, with the verdict starting on the title's row. Under a 520px container it stacks the way the card does, keyed on the hero's own width so the side panel behaves. A claim nobody has answered takes the full width. Type and tag chips are gone; Controversial is a red chip above the title. `ClaimVerdict` is deleted — the claim page was its only caller. ## The Topics tab Topics move to their own tab, and that tab is an explore feed rather than a row of chips: a chip carries a name and nothing else, so a tab of them is a list with no way to tell which entry is worth opening. Each topic gets a card — the generic explore card plus one line of metadata naming the debates, claims and news stories attached to it — and the list is ordered by those numbers, largest first, ties breaking on claims then name. Nothing paints until every count is in, so the list cannot resequence under the reader, and a partial or failed count falls back to the claim's own order rather than ranking what it could not measure as zero. The counts are asked of `entitiesConnection` rather than `relationsConnection`, which counts links rather than things — the same claim carrying `Topics` in two spaces is two relations, 552 against 505 claims on `AI governance`. Debates are two hops, debate to claim to topic, which is what "debates connected to the attached claims" means. Batched at ten topics per request; across 3,000 claims sampled from testnet the largest carries 10 topics, so this is one request in practice. ## Shared card chrome The card frame, default body and actions row move out of `explore-feed-card` into `explore-card-chrome`, so the topic card is the generic card with a `meta` slot rather than a third copy of that layout — the first two copies drifted. `META_SEGMENT_CLASS` and `ExploreFeedCommentLink` are shared for the same reason. `PersonRecordFeed` gained a `renderCard` override and draws the tab, as the Sources tab already does for the same shape of question. ## Also A full-width debate raises its column ceiling to the container rather than dropping the viewport-height budget, so the whole card still fits the screen it is watched on. The hero reserves its verdict track while the counts are unknown and releases it only on a measured zero, so the title does not re-wrap on load or on a failed count. `ClaimSideResponders` gains a "6 people agree" title, profile-picture-first ordering and browse-sidebar hover, wherever that popover opens. Reviewed across three Copilot passes; five findings fixed, two declined with reasons on the PR. Every behavioural fix has a test that was checked against the old behaviour. Not verified: the full-width debate card's two-video layout, which needs an authenticated session — a logged-out card falls back to the generic one.
The claim page's hero now uses the Explore claim card's layout at page scale, so a claim looks the same wherever you meet it. Topics move to their own tab. Most of the change is to the claim page; the shared components that gain options are listed under Outside the claim page.
Hero
claim-card-narrow, the card's own breakpoint) it stacks the way the card does, with the verdict below the pills and no rule. The hero is its own@container, so the switch follows the hero's width, not the window's. That's what matters in the side panel.master(24px, 28px from a 560px column).Topics
/topics, after Related claims. It lists every topic, uncapped, and only appears when the claim has topics, the same way Sources does. It uses the sharedClaimRecordPagelike the other record routes.SHOW_HERO_TOPICS = false) while we decide on it. In the side panel, "See all" switches the panel's tab rather than navigating the page behind.Responder list (the popover under "6 agree")
rounded-lgandhover:bg-grey-01inside a 4px inset.Debates tab
Activity section
Outside the claim page
ClaimVerdictColumn: now exported fromclaim-explore-feed-card.tsxfor the hero. Nothing else in that file changes.ClaimVerdictremoved:claim-verdict.tsxand its tests are deleted. The claim page was its only caller.RelationChipSection: gainscap, defaulting to the existing 8. The Topics tab passesInfinity.ClaimSideResponders: the title, sort and hover changes apply everywhere the list opens, so the Explore claim cards get them too.MemberRow: gains an optionalclassName. The space members and editors lists don't pass one and are unchanged.DebateExploreFeedCard: gainsfullWidth, passed throughExploreFeedCard(fullWidthDebate) andPersonRecordFeed(fullWidthDebates). All off by default; only the claim page's Debates tab turns it on.button.tsxanddebate-feed-player.tsx: these changes come with the feat(profile): restyle the personal space profile #2514 Activity header.Checks
tsc --noEmitis clean.🤖 Generated with Claude Code