Repository navigation
feat: sticky entity header with name, avatar and vote controls #2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6b3d1a0
feat: keep the entity's name and interaction in view while scrolling
jwalkingjew 8745c54
fix: raise the sticky header on a topic page too
jwalkingjew aed2c83
fix: let the sidebar toggle and the responder faces be clicked
jwalkingjew fa5d4c0
fix: order the bar's controls and stop it cutting the sidebar rail
jwalkingjew 99ec92e
fix: line the sticky bar up with each page's own content column
jwalkingjew fcf76c8
test: pin the sticky bar's re-measure on a column or host resize
jwalkingjew 95622b3
fix: review findings on the sticky entity header
jwalkingjew a14efc6
fix: keep the sticky bar off side-panel titles, and repair the layout…
jwalkingjew 6ba5fa5
fix: read the sheet's popover container where opening re-renders
jwalkingjew 0195060
fix: no stale frame on navigation, no prose in the 48px bar
jwalkingjew 2235915
fix: measure a swapped-in title instead of inheriting the old one's a…
jwalkingjew f5eda1f
fix: measure the content column before paint, not after it
jwalkingjew 64b6170
test: cover the third prose state compact suppresses
jwalkingjew 6b2f049
Merge origin/master into the sticky entity header
jwalkingjew 4678d7b
fix: keep the vote confirmation announced, and key the bar's media
jwalkingjew 32ca6f2
fix: ignore notifications about a title already dropped
jwalkingjew 912c674
fix: ignore a retired observer, and correct two stale contracts
jwalkingjew f60deb1
Merge branch 'master' into preston/sticky-entity-header
jwalkingjew 1518529
fix: show a progress cursor on the thumbs while a vote confirms
jwalkingjew 719c79c
fix: make the thumbs behave like the claim pills while a vote confirms
jwalkingjew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.