Skip to content

fix: normalize decimal values in encoders and decoder #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikgraf merged 9 commits into from
Mar 10, 2026
Merged

fix: normalize decimal values in encoders and decoder #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c3cc582
fix: normalize decimal values in encoders and decoder
baiirun Mar 9, 2026
76357f9
Align decimal normalization across Rust and TypeScript
nikgraf Mar 10, 2026
10884ca
Canonicalize decimal big mantissas across Rust and TypeScript
nikgraf Mar 10, 2026
6489fbf
Reject empty DECIMAL byte mantissas in Rust and TypeScript
nikgraf Mar 10, 2026
334f5a4
Fix TypeScript build after decimal canonicalization rewrite
nikgraf Mar 10, 2026
411af3e
Harden decimal exponent and mantissa validation in Rust and TypeScript
nikgraf Mar 10, 2026
bc0e921
Reject empty decimal big mantissas on encode
nikgraf Mar 10, 2026
6279db6
Bound decimal normalization work and align encode-time limits
nikgraf Mar 10, 2026
19793c9
add changeset
nikgraf Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions encoding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,9 @@ Embedding:
> - If mantissa fits in signed 64-bit integer (-2^63 to 2^63-1), `mantissa_type` MUST be `0x00` (varint).
> - `mantissa_type = 0x01` (bytes) is reserved for values outside int64 range.
> - When `mantissa_type = 0x01`, mantissa bytes MUST be big-endian two's complement, minimal-length (no redundant sign extension).
> - Non-compliant encodings MUST be rejected (E005).
> - Encoders MUST emit normalized DECIMAL values.
> - Decoders SHOULD accept legacy non-normalized DECIMAL values and normalize them after decoding.
> - Non-minimal mantissa bytes MUST be rejected (E005).

---

Expand Down Expand Up @@ -417,7 +419,6 @@ Indexers MUST reject edits that fail structural validation:
| Varint encoding | Overlong encoding or exceeds 10 bytes |
| Reserved bits | Non-zero |
| Mantissa bytes | Non-minimal encoding |
| DECIMAL normalization | Mantissa has trailing zeros, or zero not encoded as {0,0} |
| Signatures | Invalid (if governance requires) |
| BOOLEAN values | Not 0x00 or 0x01 |
| POINT bounds | Latitude outside [-90, +90] or longitude outside [-180, +180] |
Expand Down
Loading