Checkpoint Format Update - #617
Open
feathern wants to merge 27 commits into
Open
Conversation
old checkpoint format.
n_active_scalars and n_passive_scalars were getting double counted
Now also calls compare_check.py
Rayleigh 1.3 now compiles with -devel flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready for review, but please don't merge yet -- I would like to run a few more tests while it is being reviewed.
This PR updates the format of the checkpoint files so that the Adams-Bashforth terms are stored in terms of Chebyshev coefficients instead of on the physical-space radial grid. This is the same format as that already used for the state vector fields (W,P,S,Z,C,A).
A side effect of this change is that the radial resolution can now be degraded, if desired, on restart. This was previously not supported.
Included in this PR:
The checkpoint_version variable has been updated from 2 to 3.
Compatibility for reading version=2 checkpoints has been retained.
Rayleigh now allows the user to degrade the resolution of a version=3 checkpoint. If this is attempted for a version=2 checkpoint, Rayleigh exits and prints an error message that also provides instructions to the user describing how to convert to version=3 so that radial resolution can be degraded. This feature is not yet supported for multi-domain models.
Compatibility with multi-domain checkpoints is otherwise retained.
I had to make a small change to Fields.F90 that crept in when the compressible branch was initially merged. Without it, n_active_scalars and n_passive_scalars were getting counted twice when setting the buffer size for wsp%p1b, which holds the Adams Bashforth terms and is needed for checkpointing.