Bug Fix: IO Buffer Used Before Initialization - #638
Merged
Conversation
Contributor
Author
|
Just a quick note, you can see the crash clearly in the custom-reference testing section of my draft PR #637 . It looks like I introduced this bug two years ago, but I'm still unclear on why the tester is passing even with the crash. |
tukss
approved these changes
Jul 24, 2026
tukss
left a comment
tukss
left a comment
Contributor
There was a problem hiding this comment.
Makes sense. Not sure why it didn't crash in the test either. Have a look at the stylistic comment.
Co-authored-by: Philipp Edelmann <edelmann-github@fs.tum.de>
Contributor
Author
|
Great. I accepted the change and will merge once the tests clear again. Thanks for the quick review. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug that was causing the IO Buffer's print method to be called before the buffer was initialized. This bug seemed to only arise when reference_type=4 was used along with benchmarking mode. What's odd is that it was causing a crash in the custom-reference-state test, but that crash wasn't causing the tester to throw an error.
It would be good to review/approve quickly if you have a minute @tukss @illorenzo7 @cianwilson