Skip to content

Bump to testcontainers 2.0.1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elahrvivaz merged 1 commit into from
Nov 11, 2025
Merged

Bump to testcontainers 2.0.1 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions testcontainers/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@

<jdk.version>17</jdk.version>

<geomesa.version>5.3.0</geomesa.version>
<testcontainers.version>1.21.0</testcontainers.version>
<testcontainers.accumulo.version>1.4.1</testcontainers.accumulo.version>
<geomesa.version>5.4.0</geomesa.version>
<testcontainers.version>2.0.1</testcontainers.version>
<testcontainers.accumulo.version>1.6.0</testcontainers.accumulo.version>
<slf4j.version>1.7.36</slf4j.version>
<reload4j.version>1.2.25</reload4j.version>

Expand Down Expand Up @@ -87,6 +87,8 @@
<version>${central.publishing.maven.plugin.version}</version>
<extensions>true</extensions>
<configuration>
<autoPublish>true</autoPublish>
<deploymentName>testcontainers-hbase-${project.version}</deploymentName>
<!-- used to lookup credentials in ~/.m2/settings.xml -->
<publishingServerId>sonatype</publishingServerId>
</configuration>
Expand Down
5 changes: 2 additions & 3 deletions testcontainers/src/main/java/org/geomesa/testcontainers/hbase/HBaseContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import org.testcontainers.containers.output.OutputFrame;
import org.testcontainers.containers.output.Slf4jLogConsumer;
import org.testcontainers.containers.wait.strategy.Wait;
import org.testcontainers.shaded.org.apache.commons.io.IOUtils;
import org.testcontainers.utility.DockerImageName;

import java.io.File;
Expand Down Expand Up @@ -83,7 +82,7 @@ public HBaseContainer(DockerImageName imageName) {
.onExit()
.thenApply((p) -> {
try (InputStream is = p.getInputStream()) {
return IOUtils.toString(is, StandardCharsets.UTF_8).trim();
return new String(is.readAllBytes(), StandardCharsets.UTF_8).trim();
} catch (IOException e) {
logger.error("Error reading hostname:", e);
return null;
Expand Down Expand Up @@ -139,7 +138,7 @@ public HBaseContainer withGeoMesaDistributedRuntime(String jarHostPath) {
* @return contents of the hbase-site.xml
*/
public String getHBaseSiteXml() {
return copyFileFromContainer("/opt/hbase/conf/hbase-site.xml", (is) -> IOUtils.toString(is, StandardCharsets.UTF_8));
return copyFileFromContainer("/opt/hbase/conf/hbase-site.xml", (is) -> new String(is.readAllBytes(), StandardCharsets.UTF_8));
}

private static int getFreePort() {
Expand Down
Loading