ci: fail-closed NuGet publish unless NUGET_PUBLISH_ENABLED=true - #219
Merged
Merged
Conversation
Gate the Release publish job on vars.NUGET_PUBLISH_ENABLED, matching CancelCop. Unset or false skips nuget push even if a v* tag fires. Co-authored-by: George Wall <georgepwall1991@users.noreply.github.com>
georgepwall1991
marked this pull request as ready for review
September 15, 2026 09:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold nuget.org publishing unless the repo Actions variable
NUGET_PUBLISH_ENABLEDis explicitly'true', matching CancelCop.Analyzer.Why
Unsigned
v*tags currently fire.github/workflows/release.ymlanddotnet nuget push. George (via CoS) authorised a default-disable. This gate is fail-closed: unset or any value other than'true'skips thepublishjob even if a Release/tag fires.Change
On the
publishjob (the job that runsdotnet nuget push):Explicitly not in this PR
NUGET_PUBLISH_ENABLED(leave unset)Note
gh workflow disable Releasefrom this agent returns 403 (actions=writemissing). Until someone with repo admin disables workflow id210954591, this job-levelifis the in-repo stop for nuget.org pushes.