Skip to content
This repository was archived by the owner on Dec 30, 2025. It is now read-only.

fix GeoServerRESTPublisher::appendParameters ArrayIndexOutOfBoundsException #211

Open
makosteel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix GeoServerRESTPublisher::appendParameters ArrayIndexOutOfBoundsException #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 12 additions & 28 deletions src/main/java/it/geosolutions/geoserver/rest/GeoServerRESTPublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2911,37 +2911,21 @@ protected String sanitize(String s) {
*/
private String appendParameters(NameValuePair... params) {
StringBuilder sbUrl = new StringBuilder();
// append parameters
if (params != null) {
final int paramsSize = params.length;
if (paramsSize > 0) {
int i = 0;
NameValuePair param = params[i];
while (param != null && i++ < paramsSize) {
final String name = param.getName();
final String value = param.getValue();
// success
if (name != null && !name.isEmpty() && value != null && !value.isEmpty()) {
sbUrl.append(name).append("=").append(value);
// end cycle
param = null;
if (params != null && params.length > 0) {
boolean noLongerFirst = false;
for (NameValuePair param : params){
final String name = param.getName();
final String value = param.getValue();
if (name != null && !name.isEmpty() && value != null && !value.isEmpty()) {
// valid parameter to pass
if(noLongerFirst){
// add successive parameters (if any)
sbUrl.append("&").append(name).append("=").append(value);
} else {
// next value
param = params[i];
}
}
for (; i < paramsSize; i++) {
param = params[i];
if (param != null) {
final String name = param.getName();
final String value = param.getValue();
//add the first parameter
sbUrl.append(name).append("=").append(value);
if (name != null && !name.isEmpty() && value != null && !value.isEmpty()) {
sbUrl.append("&").append(name).append("=").append(value);
}

noLongerFirst = true;
}

}
}
}
Expand Down