Enhance filename sanitization & Readme#31
Open
josh-abram wants to merge 4 commits into
Open
Conversation
Improve filename handling & readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance Filename Sanitization & Readme
This PR improves the filename sanitization process in the Confluence exporter script. Specifically, it stops the script from erroring when it encounters additional invalid characters or confluence articles with a long name.
The readme has been updated for additional clarity.
Enhanced the __sanitize_filename method to handle more invalid characters
Implemented filename truncation for long filenames which would otherwise cause the script to error
Improved the readme