Make VerificationMethod.init public - #60
Merged
germ-mark merged 2 commits intoAug 19, 2026
Merged
Conversation
Only code inside this package could construct a VerificationMethod, so a resolver adapter in another package that is handed a signing key directly rather than a full DID document — Slingshot's resolveMiniDoc — had no way to publish it and shipped verificationMethod: []. Matches Service's initializer, already public. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c33db52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Slingshot's adapter no longer ships an empty verificationMethod, so "today's ... builds a document with verificationMethod: []" was about to go wrong the moment this repo's own change reached Microcosm. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
germ-mark
deleted the
mark/ger-2268-resolver-authority-carry-signing_key-into-verificationmethod
branch
August 19, 2026 16:45
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only code inside this package could construct a
VerificationMethod, so aresolver adapter in another package that is handed a signing key directly
rather than a full DID document — Slingshot's
resolveMiniDoc, which returnssigning_keyon the wire — had no way to publish it and shippedverificationMethod: [].AtprotoTypesVerify'sRepoSigningKeythen refusesevery document that resolver produces, and since
germ-atproto-resolver'soptimizedResolveraces Slingshot against a plc.directory query, whether arepo proof verifies depends nondeterministically on which resolver wins.
Matches
Service's initializer, already public. No behavior change, no newtests — an access-level widening has no behavior to pin, and
RepoProofVerifierTestsalready covers accept/refuse for every method shape.Unblocks a Microcosm PR that populates the field from the signing key it
already decodes.
Part of GER-2268.
🤖 Generated with Claude Code