Adopt swift-format, enforce lint in CI - #62
Merged
Conversation
.swift-format already matched jxl-encoder-swift's config byte-for- byte but wasn't enforced anywhere. Reformatted (swift format format -i --recursive) and fixed the two real lint failures it surfaced: a snake_case constant (sha2_256 -> sha2256) and an over-length end-of-line comment in Point.swift, moved above the line. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Keeps git blame (and GitHub's blame view) attributing lines to their original author instead of the mass-reformat commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
New standalone job in ci-linux.yml, since linting only needs the Swift toolchain — no package resolution, private SSH deploy keys, or Xcode pinning like the other workflows. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The strict-lint fix for sha2_256 dropped the underscore literally instead of using the conventional name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copies the existing org-standard
.swift-formatconvention, runsswift format format -iacross the tree, fixes the two real strict-lint failures (asha2_256→sha256naming fix, an over-length trailing comment), and adds a CI job enforcingswift format lint --strictso it can't silently drift again. Also adds.git-blame-ignore-revsfor the reformat commit.Part of an org-wide sweep bringing consistent swift-format lint to Germ's standalone Swift packages.