Add dual MIT/Apache-2.0 license and fill in package metadata - #126
Merged
Conversation
The repo was public with no license file at all, while rust/Cargo.toml already declared "MIT OR Apache-2.0" — a promise with nothing backing it. Also corrects docs that still pointed at Sources/AbstractTwoMLS/ (moved to a separate package) and at the vendored binding's old location, including the path in the binding-contract mismatch error, which named the wrong file to re-sync. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4eb5e00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
buildAndroid/ and the .artifactbundle it holds are build products, like buildIos/ beside them. The static libs were already covered by *.a, but info.json and the per-arch Headers/ were left showing as untracked. Matches scripts/buildAndroid.sh's output paths on the android spike branch, whose .gitignore this now equals verbatim. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo is public but had no license file, while
rust/Cargo.tomlalready declaredlicense = "MIT OR Apache-2.0"— a promise with no text behind it. This adds both license texts so that declaration is true, rather than narrowing it.LICENSE-MIT+LICENSE-APACHE(Copyright (c) 2026 Germ Network, Inc.). The Apache body was diffed against the copy vendored in ourmls-rscheckout and is byte-equivalent. Appendix omitted, matching serde and mls-rs.CONTRIBUTING.mdandREADME.md, so inbound-equals-outbound is stated rather than assumed.package.jsongainsdescription/license/author/repository;rust/fuzz/Cargo.tomlgainslicense(it's a standalone workspace and inherits nothing).Also fixes docs that still referenced
Sources/AbstractTwoMLS/, which moved to a separate package. The one worth calling out is in the binding-contract mismatch error atSources/TwoMLSPQ/PQSession.swift:259— it told developers to re-syncSources/TwoMLSPQ/two_mls_pq.swift, which no longer exists, at exactly the moment they'd be trusting that message. All automation already used the correctSources/TwoMLSPQBinding/path.Second commit ignores the Android build outputs (
/buildAndroid,*.artifactbundle). The static libs were already covered by*.a, butinfo.jsonand the per-archHeaders/were left untracked. These two lines are verbatim the ones already on the android spike branch, so.gitignoreis now identical on both and cannot conflict when that work lands.Test notes
cargo deny check licenses→licenses ok.taplo fmt --check,cargo fmt --all --check, and both clippy invocations exit 0.swift format lintdiffed before/after shows zero new warnings. No Rust or Swift behavior changes — the only code edit is a string literal. Verified the new ignore rules shadow no tracked file.Repo homepage and topics were set separately via
gh repo edit; GitHub's license badge will populate once this merges tomain.🤖 Generated with Claude Code