Adopt swift-format, enforce lint in CI - #128
Merged
Merged
Conversation
.swift-format ({"indentation": {"tabs": 1}}) was already committed but
unenforced. Ran swift format format -i --recursive, then fixed the one
real lint failure (an over-length end-of-line comment in
PQInvitationTests.swift). Left Sources/TwoMLSPQBinding/two_mls_pq.swift
alone — it's uniffi-autogenerated ("don't mess with it", swiftlint
disabled) and gets re-synced from the Rust build, so formatting it here
would just drift again on the next re-sync.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Keeps git blame (and GitHub's blame view) attributing lines to their original author instead of the mass-reformat commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
.swift-format was committed but nothing ran it. Scoped to Sources/TwoMLSPQ + Tests — Sources/TwoMLSPQBinding/two_mls_pq.swift is uniffi-autogenerated and re-synced from the Rust build, so it isn't a useful lint target. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs swift-format across the tree (config already present but unenforced, or newly added where missing), fixes any real strict-lint failures, adds a CI job running
swift format lint --strict, and adds.git-blame-ignore-revsfor the reformat commit.Part of an org-wide sweep bringing consistent swift-format lint to Germ's standalone Swift packages.