Import Crypto from swift-crypto instead of CryptoKit - #56
Merged
Conversation
CryptoKit is Apple-only and was the last blocker to building this package for Linux and Android; the API surface used (Curve25519, SymmetricKey, SHA256, ChaChaPoly, HPKE) is covered by swift-crypto, which delegates to CryptoKit on Apple platforms. AtprotoTypes floor moves to 0.5.0, the first release that builds on those platforms. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c72d48c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unguarded
import CryptoKitacross 46 files was the last blocker to buildingthis package for Linux and Android. swift-crypto covers the entire API surface
used here —
Curve25519.Signing/.KeyAgreement,SymmetricKey,SHA256,ChaChaPoly,HPKE— and delegates to CryptoKit on Apple platforms, sobehavior is unchanged there. No
SecureEnclave,SecKey, or Keychain usageanywhere, so nothing needed redesign; the swap is mechanical.
Also raises the AtprotoTypes floor to 0.5.0, the first release that builds on
those platforms, stated in the manifest for the same reason as the swift-bases
floor: consumers ignore this package's lockfile.
All 157 tests pass on macOS. The Linux and Android CI legs that prove the other
platforms land stacked on this in #52.
Part of GER-2175.
🤖 Generated with Claude Code