Enforce swift-format lint in CI - #58
Merged
Merged
Conversation
Ran swift format format -i --recursive --configuration .swift-format Sources Tests: no changes, the tree already matched the config. swift format lint --strict surfaced one real failure — an end-of-line comment in MailboxGrantTests.swift that pushes past the line length once tab expansion is counted — fixed by moving it above the line it annotates. Also flagged two AvoidRetroactiveConformances findings in Curve25519+SigningKey.swift (the @retroactive Equatable/Hashable conformances PublicSigningKey requires on a type swift-crypto doesn't supply them for) — left as-is; not a mechanical fix and not disabled. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Keeps git blame (and GitHub's blame view) attributing lines to their original author instead of the reformat commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sits in ci-linux.yml alongside the Linux test job since it needs no Xcode/Apple toolchain and no private-dep deploy keys — just the swift:6.2 container already used for swift test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Resolves the AvoidRetroactiveConformances strict-lint failures. Nothing in this package -- or any known consumer checked out locally (CoreAppLogic's three subpackages, germ-service-client, prototype-germ-service-client) -- hashes or compares a PublicSigningKey directly: AgentPublicKey, IdentityPublicKey, and AnchorPublicKey each derive their own Hashable/Equatable from a wireformat-backed id instead. Removing the requirement drops the need for the two @retroactive Curve25519.Signing.PublicKey -> Equatable/Hashable conformances entirely. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one real strict-lint failure (an over-length trailing comment) and adds a CI lint job.
Also fixes the two
AvoidRetroactiveConformancesfindings that surfaced:PublicSigningKeyrequiredHashable, forcing@retroactive Equatable/Hashableconformances onCurve25519.Signing.PublicKey. Checked every concrete consumer (AgentPublicKey,IdentityPublicKey,AnchorPublicKey) — none of them actually hash/compare aPublicSigningKeydirectly, they all deriveHashable/Equatablefrom a wireformat-backedidinstead. Also grepped known downstream consumers checked out locally (CoreAppLogic's three subpackages, germ-service-client, prototype-germ-service-client) for any reference toPublicSigningKey— none found. Dropped the requirement rather than keep the retroactive conformances — all 157 tests pass.Part of an org-wide sweep bringing consistent swift-format lint to Germ's standalone Swift packages.