Fix new groups not appearing in menu list

[gerrywastaken]

When creating a new group, autoSaveGroup() was returning early because new groups have an empty ID. This prevented them from being saved to storage and appearing in domain configuration menus.

Now autoSaveGroup() generates a UUID for new groups, adds them to the groups array, saves to storage, and calls render() to update domain menus with the new group.

[github-actions]

🤖 Hi @gerrywastaken, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

[gemini-code-assist]

Summary of Changes

Hello @gerrywastaken, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug preventing newly created groups from being saved and displayed within the application's domain configuration menus. The autoSaveGroup function has been refactored to correctly identify and process new groups by assigning them a unique ID, persisting them to storage, and triggering a UI refresh, thereby ensuring a seamless user experience when creating new groups.

Highlights

• Bug Fix: Addressed an issue where newly created groups were not appearing in the menu list due to autoSaveGroup() returning early for groups without an ID.
• UUID Generation: Implemented UUID generation for new groups within the autoSaveGroup() function, ensuring each new group receives a unique identifier.
• Group Persistence and Rendering: Ensured that new groups are properly added to the global groups array, saved to storage, and that the render() function is called to update domain menus with the newly created group.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

ext: makeitpop-build-9866949.zip
sha: 9866949

[github-actions]

🤖 I'm sorry @gerrywastaken, but I was unable to process your request. Please see the logs for more details.

[gemini-code-assist]

Code Review

The pull request refactors the autoSaveGroup function in src/settings/components/groupCard.ts to properly handle the creation and saving of new groups. Previously, the function would exit if a group did not yet have an ID. Now, it introduces an isNewGroup flag; if true, a new UUID is generated, assigned to the card, and a new Group object is constructed with its properties, added to the global groups array, saved to storage, and the UI is re-rendered. The logic for updating existing groups is now executed only when isNewGroup is false. There are no review comments provided for these changes.