Skip to content

Refactor DbContextManager to correctly handle async sessions and increase pool size #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edulauer merged 2 commits into from
Oct 10, 2025
Merged

Refactor DbContextManager to correctly handle async sessions and increase pool size #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01ad271
increase pool_size to avoid QueuePool limit
edulauer Oct 10, 2025
11309df
Refactor DbContextManager
edulauer Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/db_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@

SQLALCHEMY_DATABASE_URL = os.environ["SQLALCHEMY_DATABASE_URL"]

engine = create_async_engine(SQLALCHEMY_DATABASE_URL)
engine = create_async_engine(
SQLALCHEMY_DATABASE_URL,
pool_size=15,
max_overflow=15,
pool_timeout=30,
)
sync_engine = create_engine(SQLALCHEMY_DATABASE_URL)

async_session_maker = async_sessionmaker(engine, expire_on_commit=False)


# database models (SQLAlchemy)
class Base(DeclarativeBase): # pylint: disable=too-few-public-methods
"""Classe base para modelos SQL Alchemy.
Expand Down Expand Up @@ -83,10 +87,21 @@ class DbContextManager:
"""Context manager para manipulação de sessões do banco de dados.
"""
def __init__(self):
self.db = async_session_maker()
self.async_session_maker = async_session_maker
self.db = None

async def __aenter__(self):
self.db = self.async_session_maker()
return self.db

async def __aexit__(self, exc_type, exc_value, traceback):
await self.db.close()
try:
if exc_type is None:
# 2. If NO exception occurred, commit the transaction.
await self.db.commit()
else:
# 3. If an exception DID occur, roll back the transaction.
await self.db.rollback()
finally:
# 4. ALWAYS close the session.
await self.db.close()