Rank mention relevance across resource sources - #2203
Open
brsbl wants to merge 5 commits into
Open
Conversation
brsbl
force-pushed
the
bb/mention-relevance-core-thr_94xb8a4nk2-v3
branch
from
August 21, 2026 22:37
1e6fe7c to
f1f39af
Compare
brsbl
force-pushed
the
bb/mention-relevance-core-thr_94xb8a4nk2-v3
branch
from
August 27, 2026 07:51
f1f39af to
bbf34d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The composer combined mention sources in fixed source order while each resource type applied its own matching policy. An exact identity match from a later source could therefore lose to a weaker match from an earlier source, and grouped rendering could drift from the flat order used for keyboard navigation.
What changed
@bb/client-corenow owns one genericMentionCandidatemodel for every resource source. The app adapter normalizes threads, projects, sections, paths, and plugin results into visible identity, additional identity terms, supporting text, and a rendered group before applying one relevance policy:Rows keep their source group intact, groups are ordered by their strongest candidate, and original source order remains the final tie-breaker. The resulting grouped model and flattened suggestion list are produced together, so rendered sections and keyboard navigation share the same canonical order.
MentionMenunow renders that shared group model instead of rebuilding sections by resource kind.Plugin identity aliases are only one input to the generic model. The additive experimental
PluginMentionItem.experimental_searchAliasesfield lets a provider expose bounded identity terms without supplying policy-bearing numeric ranks. The server validates at most eight non-empty aliases of at most 256 UTF-8 bytes each and normalizes omission to an empty internal list. Missing wire data remains compatible with older providers and persisted responses.There are no removals or meaning changes, no SDK/version/engine-floor change, and no server/daemon protocol change. The current web and PWA composers share this implementation path.
How you verified
mainad79bbb5ec909524f8f281e62d860c588a86f332; exact PR head isbbf34d7960901ca6c5506efec32d552c4b5f4d5d.git diff --checkpassed for the exact layer.Before — fixed source order puts the weaker project match first
After — generic relevance puts the exact installed identity first
Fixes: no issue; this is the generic mention-relevance foundation for the
@Pluginreference layer.BB-Thread-ID: thr_94xb8a4nk2