Fix tab split movement and fullscreen - #2487
Merged
Merged
Conversation
brsbl
force-pushed
the
bb/fix-tab-split-actions-thr_q8degf2y66
branch
from
August 27, 2026 00:16
06c1bcc to
6c18c90
Compare
brsbl
force-pushed
the
bb/fix-tab-split-actions-thr_q8degf2y66
branch
from
August 27, 2026 20:54
2da9937 to
1dbfc83
Compare
brsbl
force-pushed
the
bb/fix-tab-split-actions-thr_q8degf2y66
branch
from
August 27, 2026 23:47
1dbfc83 to
ef22d77
Compare
SawyerHood
force-pushed
the
bb/fix-tab-split-actions-thr_q8degf2y66
branch
from
August 27, 2026 23:50
ef22d77 to
754e991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maximize pane/Restore spliton web andFull Screen/Exit Full Screenin desktop.WebContentsViewfrom covering the arrangement menu and move targets.+only in the focused split pane while reserving its space in inactive panes.Info and Diff remain fixed throughout; this layer does not make them closeable.
Screenshot evidence
Web captures use Chrome for Testing 151.0.7922.71 at the same 1440×900 CSS viewport (DPR 2) and the same one-file
Split tab UX verificationfixture. Desktop captures use Electron 41.7.0 / Chrome 146.0.7680.216 with identical 1440×900 native window bounds and the same Browser/Info split. The before revision is exact parent head35050edb632c1007f14978c6c5e5bfe4dd83a259; the after revision is exact PR head1dbfc83bd587b98968d6b0a839da9f81751ce3b9.Info move ownership
Before,
Move bottominvoked from Info moves the previously focused Diff pane instead, leaving Info above Diff.After, Info itself moves below Diff.
True pane maximization
Before, activating fullscreen expands the right panel but leaves both split panes visible.
After, Info fills the right workspace and the preserved Diff pane is hidden until restore.
Runtime-specific copy
Before, the web arrangement menu says
Full Screen.After, web says
Maximize pane.Focused-pane new-tab action
Before, the
+stays in the upper Diff pane even though the lower Info pane is focused.After, the only visible
+follows focus into the lower Info pane; the upper row keeps a reserved slot so its tabs do not shift.Desktop Browser overlay
Before, the native Example Domain view paints over the renderer menu, leaving only the
Full Screenrow visible.After, desktop retains
Full Screencopy and the complete Move grid renders above the Browser surface.Info scrollbar final behavior
At rest after a completed scroll, the overflowing Info pane has no visible thumb.
During active scrolling in the same layout, the thumb is visible at the right edge.
Validation
+ownership, and transparent/active scrollbar states.screencapture, not a renderer-only image, so it includes theWebContentsViewthat caused the clipping.BB-Thread-ID: thr_q8degf2y66