Add Junie as an ACP provider - #2535
Open
preigile wants to merge 1 commit into
Open
Conversation
Co-authored-by: Junie <junie@jetbrains.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
Support for the Junie agent has been added via the ACP
What was wrong
bb had no registration for JetBrains' Junie
What changed
packages/provider-bridge-acp/src/wire.ts:SessionConfigSelectOptionsis parsed as the union the ACP spec defines, and groups are flattened to their values (bb has no grouped picker). The lenient path for non-model options flattens groups the same way. Any ACP agent that groups its options benefits, not only Junie.packages/provider-bridge-acp/src/bridge/provider-maintenance.ts:loginCommand,readAccountandreadUsageare optional. Health reports an installed agent whose credentials bb cannot read as ready instead of guessing "signed out", and usage withoutreadUsageissupported: false. AddedJUNIE_ACP_MAINTENANCE– installer only, JetBrains' documented script – andpackages/provider-bridge-acp/src/dialect.tsgains thejuniedialect that carries it (Junie reads no vendor side channel; the dialect exists only for that).plugins/provider-acp: theacp-junieagent (junie --acp true,.junie/skillsand.agents/skillsnative roots,fork: "none"until Junie'sinitializereply is verified), its brand icon, andproviderInstallationso bb installs the CLI itself the same shape asacp-cursor. The agent is listed whether or not the CLI is present, because an installed-only listing hides the row the Install action lives on. Reserving an id is now an explicitreservedflag instead of a side effect of always being listed, soacp-juniestays overridable viacustomAgentswhileacp-cursordoes not.apps/web: the Junie mark in the "Works with" row and in the two provider lists on the landing page.docs/configuration.md, the bb providers guide template, the bb-cli skill, the bb-app README.No host-daemon wire change: the dialect id travels in the existing
providerOptions, soHOST_DAEMON_PROTOCOL_VERSIONis unchanged.How you verified