Align follow-up composer stack carets - #2585
Open
brsbl wants to merge 4 commits into
Open
Conversation
brsbl
force-pushed
the
bb/align-composer-stack-carets-thr_sjdd7gudiq
branch
from
August 28, 2026 00:06
1209ee0 to
f9633dd
Compare
brsbl
force-pushed
the
bb/align-composer-stack-carets-thr_sjdd7gudiq
branch
from
August 28, 2026 00:44
f9633dd to
400f7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The three right-edge disclosure controls in the follow-up composer stack did not share a horizontal geometry contract. The branch and queued-message controls centered their 16px chevrons in a 24px edge column, while the composer collapse control used a 32px icon button against the same right edge. That put the composer caret four pixels left of the carets above it.
What changed
How you verified
w-6.400f7c6674cbeb5a1df9c2f331f97b020865c3bapasses every required GitHub check, including all app shards, packages, server, integration, and Linux/macOS package smoke.Stacked cards with pillsfixture at 1440×900 on exact parent and child heads. On the child, branch, queue, and composer caret centers all measured x=1019; the deliberate real-app pass also covered expanded/collapsed behavior, plus/model menus, focus re-expansion, responsive overflow, and runtime exceptions. The later rebase changed only ancestor SDK inventory metadata, not this layer's app tree. Safari is not required for this non-marketing bb UI change.Before — parent head
f4707e0ad2ea6622fa4c314e943c6735a1d21f34The composer caret sits four pixels left of the banner and queue carets.
After — child head
400f7c6674cbeb5a1df9c2f331f97b020865c3baAll three carets share the same horizontal center.
BB-Thread-ID: thr_sjdd7gudiq