Fix workflow panel early-state spacing - #2588
Merged
ymichael merged 4 commits intoAug 27, 2026
Merged
Conversation
ymichael
deleted the
bb/fix-workflow-panel-early-padding-thr_kc4mtxnwqs
branch
August 27, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The workflow thread panel uses the shared flush layout, so the plugin must own padding and scrolling in every state. Loading, initial RPC error, and no-run branches returned before any local spacing owner and rendered edge-to-edge, while the status primitives also added a second layer of margins, padding, borders, radius, and muted surface once the missing outer inset was restored.
What changed
Add one shared
WorkflowRunPanelStateframe that owns the 16px inset for invalid parameters and every early branch. Flatten the loading and empty/error primitives so they own only their semantic content and skeleton layout. Add a table-driven regression for the three asynchronous early states and a real SDK-backed Ladle story covering all non-loaded states plus a terminal loaded run. Loaded scrolling, terminal/footer behavior, the host flush contract, wire contracts, CLI surfaces, and public Plugin SDK APIs are unchanged.How you verified
pnpm exec turbo run test --filter=bb-plugin-workflows --force(13 files, 226/226 passed)pnpm exec turbo run typecheck --filter=bb-plugin-workflowspnpm exec turbo run typecheck --filter=@bb/appgit diff --check origin/main...HEAD