Fix/bc pay button accessibility#361
Draft
divyansh-v15-06 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the accessibility and interaction handling of the bc-pay-button component.
What changed
Removed nested interactive elements by making bci-button the single interactive control
Simplified keyboard interaction by relying on native button behavior
Added clear, state-based aria-label values for screen readers
Preserved existing payment flow and state logic without behavior changes
Why
The previous structure wrapped a button-like component inside another interactive element, which can cause accessibility issues for keyboard and screen reader users. This update aligns the component with best practices by ensuring a single, semantically correct interactive element.
Impact
Improves accessibility and WCAG compliance
Keeps behavior unchanged for existing integrations
Makes the component consistent with other Bitcoin Connect buttons